This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert skiping illegal render in Dart #49473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
approved these changes
Jan 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 3, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 3, 2024
…140905) flutter/engine@98b72c7...c62bcff 2024-01-03 [email protected] [Impeller] Disable compute for Vulkan. (flutter/engine#49463) 2024-01-03 [email protected] Revert skiping illegal render in Dart (flutter/engine#49473) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
dkwingsmt
added a commit
to dkwingsmt/engine
that referenced
this pull request
Jan 11, 2024
This reverts commit 4325486.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the following two PRs:
Effectively,
which means that the illegal renders will take effect in release mode, the mode that the benchmarks are performed in.
This is due to a discovery that the revert #49238 did not bring back the performance. We suspect that some other changes after the culprit (#47239) is also responsible for the regression, which narrows down to just one PR, #47323, which also makes sense. By reverting this change, we'll draw a final conclusion whether the regression is caused by illegal renders.
After this revert, the engine is in a temporary state due to the different behaviors between modes.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.