This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Start wiring up fragment program for OpenGLES #49347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jan 2, 2024
impeller/aiks/aiks_unittests.cc
Outdated
| // Regression test for https://github.com/flutter/flutter/issues/126701 . | ||
| TEST_P(AiksTest, CanRenderClippedRuntimeEffects) { | ||
| if (GetParam() != PlaygroundBackend::kMetal) { | ||
| if (GetParam() == PlaygroundBackend::kVulkan) { |
Member
There was a problem hiding this comment.
Perhaps move this to PlaygroundTest::BackendSupportsFragmentProgram?
| ); | ||
| continue; | ||
| } | ||
| VALIDATION_LOG << "Size " << member.size |
Member
There was a problem hiding this comment.
Can't this information be combined in the validation log below?
Contributor
Author
There was a problem hiding this comment.
This one is specific for floats. The one below doesn't necessarily care about sizes, and when I hit this it was a little confusing at first about why a float wouldn't be supported.
impeller/playground/playground.h
Outdated
| kVulkan, | ||
| }; | ||
|
|
||
| inline RuntimeStageBackend PlaygroundBackendToRuntimeStageBackend( |
Member
There was a problem hiding this comment.
constexpr with an FML_UNREACHABLE at the end.
Member
|
Perhaps flutter/flutter#105538 as a related issue. |
bdero
approved these changes
Jan 2, 2024
Contributor
|
auto label is removed for flutter/engine/49347, due to - The status or check suite Mac mac_clang_tidy has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 3, 2024
…140839) flutter/engine@b02d59a...b5e79bd 2024-01-02 [email protected] Start wiring up fragment program for OpenGLES (flutter/engine#49347) 2024-01-02 [email protected] Roll Dart SDK from 014514e3e5b9 to 7e9f7eab80d3 (2 revisions) (flutter/engine#49471) 2024-01-02 [email protected] [web] make TextStyle implementations consistent (flutter/engine#49465) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes fragment programs work for OpenGLES backend.
Fixes flutter/flutter#113715
Fixes flutter/flutter#105538
I cannot find a dedicated issue for this, but there probably is someone somewhere and I don't want to file a new one for it.