This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Do not skip rendering when mask blur is zero #49342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
Dec 21, 2023
bdero
approved these changes
Dec 21, 2023
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 22, 2023
…140531) flutter/engine@737e6f8...1ba8fc0 2023-12-22 [email protected] Fix GetImpellerContext for ShellTestPlatformViewGL (flutter/engine#49337) 2023-12-21 [email protected] [Impeller] Remove use of private Rect fields from PathBuilder (flutter/engine#49334) 2023-12-21 [email protected] [Impeller] Do not skip rendering when mask blur is zero (flutter/engine#49342) 2023-12-21 [email protected] [Windows] Fix incorrect surface manager comment (flutter/engine#49335) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
…lutter#140531) flutter/engine@737e6f8...1ba8fc0 2023-12-22 [email protected] Fix GetImpellerContext for ShellTestPlatformViewGL (flutter/engine#49337) 2023-12-21 [email protected] [Impeller] Remove use of private Rect fields from PathBuilder (flutter/engine#49334) 2023-12-21 [email protected] [Impeller] Do not skip rendering when mask blur is zero (flutter/engine#49342) 2023-12-21 [email protected] [Windows] Fix incorrect surface manager comment (flutter/engine#49335) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original fix had a bad return value that caused the rendering to abort rather than proceed normally without the blurring.
I also changed the color being used so that the contents would show up in golden diffs which use a white background for unrendered pixels.