This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Remove PlatformWindow and RenderTarget abstractions
#49312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| window_ = window.get(); | ||
| EXPECT_CALL(*window_, SetView).Times(1); | ||
| EXPECT_CALL(*window_, GetRenderTarget).WillOnce(Return(nullptr)); |
Contributor
There was a problem hiding this comment.
Should this expect a call to GetWindowHandle?
Member
Author
There was a problem hiding this comment.
This mock used to be necessary but the implementation must have changed to no longer need it.
I've verified that the tests pass and don't output unexpected warnings without this mock. I also updated additional tests that no longer need this mock.
yaakovschectman
approved these changes
Dec 26, 2023
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 26, 2023
…140625) flutter/engine@bdf261b...38b9f3f 2023-12-26 [email protected] [Windows] Remove `PlatformWindow` and `RenderTarget` abstractions (flutter/engine#49312) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
…lutter#140625) flutter/engine@bdf261b...38b9f3f 2023-12-26 [email protected] [Windows] Remove `PlatformWindow` and `RenderTarget` abstractions (flutter/engine#49312) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows embedder has three ways to get an
HWND:GetWindowHandlewhich returns theHWNDGetPlatformWindowwhich returns theHWNDwrapped as aPlatformWindowGetRenderTargetwhich returns theHWNDwrapped as aRenderTargetThese abstractions are no longer useful now that we removed the UWP embedder. This change removes
PlatformWindowandRenderTargetand usesHWNDdirectly.This change is a refactoring with no semantic changes.