This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Migrate to Flutter mirrors for Google-owned Github repositories #49203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Jan 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 9, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 9, 2024
…141191) flutter/engine@036b39f...a35e3b0 2024-01-09 [email protected] Simplify PlatformViewRenderTarget interface (flutter/engine#49639) 2024-01-09 [email protected] Roll Skia from 05039d6ed8d8 to 8c8be76a62c0 (3 revisions) (flutter/engine#49638) 2024-01-09 [email protected] Skip flaky test on mac in http_disallow_http_connections_test.dart (flutter/engine#49635) 2024-01-09 [email protected] Resize the RenderTarget before creating and passing its Surface to the VirtualDisplay (flutter/engine#49619) 2024-01-09 [email protected] Migrate to Flutter mirrors for Google-owned Github repositories (flutter/engine#49203) 2024-01-09 [email protected] Roll Skia from ee263c34e03d to 05039d6ed8d8 (2 revisions) (flutter/engine#49636) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
|
The mirror https://flutter.googlesource.com/third_party/googleapis.dart.git is not publicly readable, so checkouts of Flutter engine aren't working on monorepo and probably for the public. I can't see the GoB ACLs for this repo, or fix them. I'll try and revert this change. |
whesse
added
the
revert
8 tasks
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Jan 10, 2024
…ies" (#49671) Reverts #49203 Initiated by: whesse This change reverts the following previous change: Original Description: Flutter dependencies coming from Github origins need to be mirrored so that they are not taken directly from github. This is part of an effort to standardize the dependency sources from third party dependencies. Google is creating internal mirrors for these public repos, but we would be limited by the relatively strict access placed on those new repos, requiring this solution of Flutter GoB mirrors (as has already been done with non-Google Github repos and also Fuchsia-owned mirrors) *List which issues are fixed by this PR. You must list at least one issue.* Addresses b/316597637 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
zanderso
added
the
revert
Contributor
|
Unable to create the revert pull request due to ProcessException: Standard out nothing to commit, working tree clean |
auto-submit
bot
removed
the
revert
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
This change integrates directly with osv-scanner rather than using the OSV API to query each dependency for vulnerabilities. - use [lockfile format](#49203) for third party deps rather than a flat file - let osv-scanner do the work of checking for vulns rather than API calls to OSV database - let osv-scanner create and populate the SARIF results A successful run of the vulnerability scanner can be seen in the tests of this PR. *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
Reland of #49203 after permissions issue. The googleapis.dart mirror is now verified to be publicly available. Also remove github dependency variable since there are no more existing uses. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flutter dependencies coming from Github origins need to be mirrored so that they are not taken directly from github. This is part of an effort to standardize the dependency sources from third party dependencies.
Google is creating internal mirrors for these public repos, but we would be limited by the relatively strict access placed on those new repos, requiring this solution of Flutter GoB mirrors (as has already been done with non-Google Github repos and also Fuchsia-owned mirrors)
List which issues are fixed by this PR. You must list at least one issue.
Addresses b/316597637
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.