This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Run tests on macOS 13 exclusively" #49115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6e3a048.
auto-submit
bot
added
the
revert of
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
approved these changes
Dec 15, 2023
auto-submit
bot
deleted the
revert_6e3a04874be56eadd4bc93c1f9de80695a3f3f61
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 16, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 16, 2023
…140262) flutter/engine@ca329dd...74e4965 2023-12-16 [email protected] Statically link swiftshader into flutter_tester (flutter/engine#48708) 2023-12-16 [email protected] [Impeller] Do not pass the depfile flag when creating a shader bundle in ImpellerC (flutter/engine#49114) 2023-12-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run tests on macOS 13 exclusively" (flutter/engine#49115) 2023-12-15 [email protected] Roll SwiftShader to 2fa7e9b99ae4e70ea5ae2cc9c8d3afb43391384f (flutter/engine#49112) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #49099
Initiated by: vashworth
This change reverts the following previous change:
Original Description:
Release team wants engine tests running exclusively on macOS 13 in main for a while before CP'ing to beta.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.