This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Do not pass the depfile flag when creating a shader bundle in ImpellerC #49114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
approved these changes
Dec 15, 2023
Member
bdero
left a comment
bdero
left a comment
There was a problem hiding this comment.
LGTM! Just a nit around what guard to use for these options.
| ] | ||
|
|
||
| if (!shader_bundle) { | ||
| depfile_path = "$generated_dir/{{source_file_part}}.d" |
Member
There was a problem hiding this comment.
Huh, it's weird that using source_file_part wasn't erroring out for action/compiled_action like the other source-based vars did when using single-invocation mode.
I think moving this behind the !single_invocation guard below would make the most sense. Even though shader_bundle mode is technically the only situation where we'll use single_invocation, we'll need to switch --iplr to behave similarly in the future once we change it to pack multiple backends into a single iplr for RuntimeEffect support on Android.
Member
Author
There was a problem hiding this comment.
Done
(source_file_part was being replaced with an empty string in the depfile path when single invocation mode invoked an action without a foreach)
jason-simmons
force-pushed
the
iplr_shader_bundle_depfile
branch
from
7ca1ed7 to
1d110d5
Compare
jason-simmons
force-pushed
the
iplr_shader_bundle_depfile
branch
from
1d110d5 to
25866cd
Compare
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 16, 2023
…der bundle in ImpellerC (flutter/engine#49114)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 16, 2023
…140262) flutter/engine@ca329dd...74e4965 2023-12-16 [email protected] Statically link swiftshader into flutter_tester (flutter/engine#48708) 2023-12-16 [email protected] [Impeller] Do not pass the depfile flag when creating a shader bundle in ImpellerC (flutter/engine#49114) 2023-12-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run tests on macOS 13 exclusively" (flutter/engine#49115) 2023-12-15 [email protected] Roll SwiftShader to 2fa7e9b99ae4e70ea5ae2cc9c8d3afb43391384f (flutter/engine#49112) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shader bundles only produce the flat buffer output and do not write a depfile.