This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Remove header guard from generated key map #48993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 13, 2023
The generated file is a `.cc` file that does not need header guards. This change updates the template that's used to generate that `.cc` file. No tests as this is a refactoring with no semantic changes. The generated `.cc` file in the engine will be updated by flutter/engine#48993
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 14, 2023
…140171) flutter/engine@997d3df...2140942 2023-12-14 [email protected] Roll Skia from 5353de0c25b9 to 92935b91193a (1 revision) (flutter/engine#49044) 2023-12-14 [email protected] Reland manual roll of Dart SDK from 82c4571bb2de to a677378ae254 (flutter/engine#49034) 2023-12-14 [email protected] [Windows] Remove header guard from generated key map (flutter/engine#48993) 2023-12-14 [email protected] [Impeller] Round rects with circular ends should not generate ellipses (flutter/engine#49021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tests as this is a refactoring with no semantic changes.
The generator was updated by flutter/flutter#140082