[Impeller] Made the new blur work on devices without the decal address mode #48899
Conversation
gaaclarke
changed the title
gaaclarke
force-pushed
the
gaussian-blur-decal-fallback
branch
from
c00223f to
307184e
Compare
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
Noting that there is already code in the gaussian blur contents to ensure that the decal sampler mode isn't selected, this patch adds selection of the correct pipeline + testing.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
fyi, I switched the test to use an image filter since that would demonstrate better decal problems. |
gaaclarke
force-pushed
the
gaussian-blur-decal-fallback
branch
from
691c75d to
f134312
Compare
|
Golden file changes are available for triage from new commit, Click here to view. |
The golden image isn't quite right. It doesn't match what I'm seeing in the playgrounds renders. It looks like it's being scaled about 2x.
|
|
Golden file changes are available for triage from new commit, Click here to view. |
|
Okay, the golden does what we expect now. I think the output looks a wee bit wonky, but this is the old blur filter. This isn't actually rendering anything new, so landing it to keep track of it for when we turn the new blur on. |
gaaclarke
added
the
autosubmit
…140090) flutter/engine@fc32677...9f7004e 2023-12-13 [email protected] [Impeller] Made the new blur work on devices without the decal address mode (flutter/engine#48899) 2023-12-13 [email protected] Allow tests to run on macOS 13 (flutter/engine#48894) 2023-12-13 [email protected] [Impeller] Compute ContextContentOptions key via bit manipulating (instead of hashing each property). (flutter/engine#48902) 2023-12-13 [email protected] Roll Skia from f3401c6186c1 to 69c02c9d56b2 (1 revision) (flutter/engine#48992) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
This also adds a new mechanism of override the device capabilities.
fixes flutter/flutter#139773
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.