Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Dec 8, 2023

As part of eliminating the Flutter buildroot (flutter/flutter#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@matanlurey matanlurey changed the title Move yapf. Move third_party/yapf to flutter/third_party/yapf. Dec 8, 2023
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 8, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 8, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 8, 2023

auto label is removed for flutter/engine/48847, due to - The status or check suite Mac mac_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 11, 2023

auto label is removed for flutter/engine/48847, due to - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 11, 2023

auto label is removed for flutter/engine/48847, due to - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2023
@matanlurey matanlurey merged commit f0ab52b into flutter:main Dec 11, 2023
@matanlurey matanlurey deleted the engine-buildmoot-yapf branch December 11, 2023 23:18
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 12, 2023
…139948)

flutter/engine@d001419...ea1a306

2023-12-11 [email protected] Roll Skia from bd5941d727be to 461256aac224 (1 revision) (flutter/engine#48897)
2023-12-11 [email protected] Move `third_party/yapf` to `flutter/third_party/yapf`. (flutter/engine#48847)
2023-12-11 [email protected] Roll Skia from 17bd70326a49 to bd5941d727be (1 revision) (flutter/engine#48896)
2023-12-11 [email protected] SemanticsUpdateBuilder migration: introduce `identifier` (flutter/engine#48882)
2023-12-11 [email protected] Add support for exposing accessibility identifier as accessibilityIdentifier on iOS (flutter/engine#48858)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants