This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Roll Clang from 00396e6a1a0b to 725656bdd885 #48817
Merged
auto-submit
merged 1 commit into
flutter:main
from
skia-flutter-autoroll:clang-flutter-engine-9937e3ac-bc85-4d5b-b173-bbd1d015983f-1701998724
Dec 8, 2023
Merged
Roll Clang from 00396e6a1a0b to 725656bdd885 #48817
auto-submit
merged 1 commit into
flutter:main
from
skia-flutter-autoroll:clang-flutter-engine-9937e3ac-bc85-4d5b-b173-bbd1d015983f-1701998724
Dec 8, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/clang-flutter-engine Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
fluttergithubbot
approved these changes
Dec 8, 2023
auto-submit bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
This reverts commit 70d87b8.
auto-submit bot
added a commit
that referenced
this pull request
Dec 8, 2023
Reverts #48817 Initiated by: zanderso This change reverts the following previous change: Original Description: If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/clang-flutter-engine Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 8, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 8, 2023
…139807) flutter/engine@6a687be...e9e0ff0 2023-12-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Clang from 00396e6a1a0b to 725656bdd885" (flutter/engine#48832) 2023-12-08 [email protected] Roll Dart SDK from be8a95b6717d to 2c928cc12f94 (6 revisions) (flutter/engine#48818) 2023-12-08 [email protected] Roll Clang from 00396e6a1a0b to 725656bdd885 (flutter/engine#48817) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso
added a commit
that referenced
this pull request
Dec 8, 2023
I'm seeing post-submit runs of full clang_tidy taking about ~20-ish minutes excluding queue time, so the premise of flutter/flutter#139769 may be incorrect. In that case, we should re-enable full clang_tidy in presubmit and observe any impacts to queue time. Context is that the clang autoroll became unblocked and landed a roll that passed clang_tidy checks in presubmit, but then failed in post submit: #48817
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/clang-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md