Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@skia-flutter-autoroll skia-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 8, 2023
@auto-submit auto-submit bot merged commit 70d87b8 into flutter:main Dec 8, 2023
@zanderso zanderso added the revert Label used to revert changes in a closed and merged pull request. label Dec 8, 2023
auto-submit bot pushed a commit that referenced this pull request Dec 8, 2023
@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Dec 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 8, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 8, 2023
…139807)

flutter/engine@6a687be...e9e0ff0

2023-12-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Clang from 00396e6a1a0b to 725656bdd885" (flutter/engine#48832)
2023-12-08 [email protected] Roll Dart SDK from be8a95b6717d to 2c928cc12f94 (6 revisions) (flutter/engine#48818)
2023-12-08 [email protected] Roll Clang from 00396e6a1a0b to 725656bdd885 (flutter/engine#48817)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso added a commit that referenced this pull request Dec 8, 2023
I'm seeing post-submit runs of full clang_tidy taking about ~20-ish
minutes excluding queue time, so the premise of
flutter/flutter#139769 may be incorrect. In
that case, we should re-enable full clang_tidy in presubmit and observe
any impacts to queue time.

Context is that the clang autoroll became unblocked and landed a roll
that passed clang_tidy checks in presubmit, but then failed in post
submit: #48817
@skia-flutter-autoroll skia-flutter-autoroll deleted the clang-flutter-engine-9937e3ac-bc85-4d5b-b173-bbd1d015983f-1701998724 branch December 15, 2023 02:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants