[Impeller] Clamp new blur sigma #48813
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| // 500 | 0.15 | ||
| // | ||
| // TODO(gaaclarke): Maybe we should just change this to a linear function. | ||
| Scalar ScaleSigma(Scalar sigma) { |
There was a problem hiding this comment.
I chose to duplicate this instead trying to share with the old blur. I want to keep it the same for now so that we get better apples to apples comparison with the benchmarks when we move it over.
gaaclarke
force-pushed
the
clamp-blur-sigma
branch
from
085189a to
21e03a2
Compare
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
gaaclarke
force-pushed
the
clamp-blur-sigma
branch
from
62f51c2 to
aea3da4
Compare
| // Use newtonian method to give the closest answer to target where | ||
| // f(x) is less than the target. We do this because the value is `ceil`'d to | ||
| // grab fractional pixels. | ||
| float LowerBoundNewtonianMethod(std::function<float(float)> func, |
There was a problem hiding this comment.
Calculus 2 days in a row, what!? 🔔
impeller/entity/contents/filters/gaussian_blur_filter_contents.cc
Outdated
Show resolved
Hide resolved
impeller/entity/contents/filters/directional_gaussian_blur_filter_contents.cc
Outdated
Show resolved
Hide resolved
impeller/entity/contents/filters/gaussian_blur_filter_contents.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Jonah Williams <[email protected]>
…ter_contents.cc Co-authored-by: Jonah Williams <[email protected]>
Co-authored-by: Jonah Williams <[email protected]>
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
…139851) flutter/engine@101396f...e80c090 2023-12-09 [email protected] [Impeller] Clamp new blur sigma (flutter/engine#48813) 2023-12-09 [email protected] Move `//third_party/tinygltf` to `//flutter/third_party/tinygltf` (flutter/engine#48852) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
fixes
AiksTests.CanRenderBackdropBlurHugeSigma/MetalI also tweaked the existing quadratic equation to make sure the minima is at 500 and
f(0) = 1.before
after
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.