This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Provide the clear color to an advanced blend if it was optimized out #48646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
impeller/entity/entity_pass.cc
Outdated
| // for blending (otherwise the blend pass will end up executing before | ||
| // all the previous commands in the active pass). | ||
|
|
||
| // If all previous elements were skipped due to clear color optimization |
Contributor
There was a problem hiding this comment.
If we applied the clear color, that means we have a single color/rectangle as a dst input. Rather than rendering the element and allocating the render target to do this, we could instead create a 1x1 host uploaded texture with the color already set - that would be much faster.
The ColorFilterContents::MakeBlend also has the option of specifying a "foreground" color, which I believe applies to the destination - the same place you'd use this texture. If this works all you need to do is conditionally pass the clear color instead of another texture which should be much simpler.
Member
Author
There was a problem hiding this comment.
Changed this to pass the clear color as the foreground color for ColorFilterContents::MakeBlend
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jason-simmons
force-pushed
the
iplr_adv_blend_clear_color
branch
from
10cd24a to
80a01d8
Compare
jason-simmons
changed the title
Contributor
|
It looks like the clear color optimization is applying to AdvancedBlendCoverageHintIsNotResetByEntityPass, so to fix that test you'd likely need to modify the drawing commands so at least one entity was drawn. |
jason-simmons
force-pushed
the
iplr_adv_blend_clear_color
branch
from
80a01d8 to
988117f
Compare
|
Golden file changes are available for triage from new commit, Click here to view. |
…imized out If all previous elements were skipped due to clear color optimization, then the clear color must be provided as the foreground to the advanced blend if framebuffer fetch is not available.
jason-simmons
force-pushed
the
iplr_adv_blend_clear_color
branch
from
988117f to
939a6a4
Compare
|
Golden file changes are available for triage from new commit, Click here to view. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2023
…it was optimized out (flutter/engine#48646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2023
…it was optimized out (flutter/engine#48646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2023
…it was optimized out (flutter/engine#48646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2023
…it was optimized out (flutter/engine#48646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2023
…it was optimized out (flutter/engine#48646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2023
…it was optimized out (flutter/engine#48646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2023
…it was optimized out (flutter/engine#48646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2023
…it was optimized out (flutter/engine#48646)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 7, 2023
…139716) flutter/engine@347f506...82de334 2023-12-07 [email protected] Revert "Replace use of Fontmgr::RefDefault with explicit creation calls" (flutter/engine#48755) 2023-12-07 [email protected] Roll Skia from 2abb01e18ab3 to 8ebf43ba1c09 (1 revision) (flutter/engine#48761) 2023-12-07 [email protected] Roll Dart SDK from dbfe4e3f867e to be8a95b6717d (1 revision) (flutter/engine#48757) 2023-12-06 [email protected] Remove obsolete properties. (flutter/engine#48753) 2023-12-06 [email protected] Roll Skia from 7ff0103760d0 to 2abb01e18ab3 (1 revision) (flutter/engine#48751) 2023-12-06 [email protected] Roll Skia from 570103e08087 to 7ff0103760d0 (1 revision) (flutter/engine#48748) 2023-12-06 [email protected] Roll Skia from 326bdc97ac40 to 570103e08087 (1 revision) (flutter/engine#48746) 2023-12-06 [email protected] Roll Dart SDK from 6eb13603c212 to dbfe4e3f867e (1 revision) (flutter/engine#48745) 2023-12-06 [email protected] [Impeller] Store Buffer/Texture bindings in vector instead of map. (flutter/engine#48719) 2023-12-06 [email protected] Roll Skia from 33cba437bf70 to 326bdc97ac40 (2 revisions) (flutter/engine#48743) 2023-12-06 [email protected] [Impeller] Provide the clear color to an advanced blend if it was optimized out (flutter/engine#48646) 2023-12-06 [email protected] [Windows] Set swap interval on raster thread after startup (flutter/engine#47787) 2023-12-06 [email protected] Roll Skia from 384d14063dc1 to 33cba437bf70 (3 revisions) (flutter/engine#48740) 2023-12-06 [email protected] [Windows] Refactor the GLES proc table (flutter/engine#48688) 2023-12-06 [email protected] Replace use of Fontmgr::RefDefault with explicit creation calls (flutter/engine#48571) 2023-12-06 [email protected] [Impeller] disable entity culling by default. (flutter/engine#48717) 2023-12-06 [email protected] Roll Skia from 23e1cb20a6b5 to 384d14063dc1 (1 revision) (flutter/engine#48738) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all previous elements were skipped due to clear color optimization, then the clear color must be rendered as an input to the advanced blend if framebuffer fetch is not available.