Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Mar 23, 2018

As of Dart 2 all non-host builds also require a host build. This updates CONTRIBUTING.md accordingly.

CONTRIBUTING.md Outdated

### Desktop (Mac and Linux), for tests

To run the tests, you should firts clone [the main Flutter repository](https://github.com/flutter/flutter).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/firts/first/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the typo.

@yjbanov yjbanov merged commit ea17fff into flutter:master Mar 24, 2018
cbracken added a commit to cbracken/flutter that referenced this pull request Mar 27, 2018
Includes:
* CONTRIBUTING.md: explain the need for building host with non-host (flutter/engine#4863
* Roll Dart to 2f68e82526d59b679a522e25db224d8c7e23d280 (flutter/engine#4864)
@yjbanov yjbanov deleted the update-contributing-md branch June 22, 2021 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants