Only run firebase tests on HEAD #48548
Conversation
* dart-internal doesn't have a firebase test lab instance
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@godofredoc should the json files be marked as test exempt? If so, I can send a Cocoon PR. Otherwise, I'll request one after this is reviewed. |
keyonghan
left a comment
keyonghan
left a comment
There was a problem hiding this comment.
Has the recipes CL been CP'ed?
No, but this needs to land as well so we can verify at HEAD. We plan to create a new beta this week, so I'd like to be able to CP it in. |
CaseyHillers
added
the
autosubmit
…139495) flutter/engine@b87c1b3...eee8aeb 2023-12-04 [email protected] Only run firebase tests on HEAD (flutter/engine#48548) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
flutter/flutter#138835
Pre-launch Checklist
///).