[Impeller] Fix size of squares in DrawPoints(PointMode). #48547
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
chinmaygarde
changed the title
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
@flar Can you triage the goldens change? It seems like the update does the right thing now but I want to make sure.
chinmaygarde
changed the title
Yes, I typically wait until after review so that reviewers can have a look. Also, we are waiting on a test exemption. |
|
test-exempt: is tested by the golden change |
…139388) flutter/engine@69f0e55...95995c4 2023-12-01 [email protected] [web] Implement multi-view for semantics (flutter/engine#48251) 2023-12-01 [email protected] [Impeller] Fix size of squares in DrawPoints(PointMode). (flutter/engine#48547) 2023-12-01 [email protected] Roll Skia from ecf10008c8bd to 5849e2b1aa8f (2 revisions) (flutter/engine#48569) 2023-12-01 [email protected] Roll Skia from 0ed7f26b3adb to ecf10008c8bd (1 revision) (flutter/engine#48568) 2023-12-01 [email protected] Roll Skia from e69fbf086bb6 to 0ed7f26b3adb (1 revision) (flutter/engine#48565) 2023-12-01 [email protected] Roll Skia from 57c6a5a97dc5 to e69fbf086bb6 (1 revision) (flutter/engine#48562) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#139388) flutter/engine@69f0e55...95995c4 2023-12-01 [email protected] [web] Implement multi-view for semantics (flutter/engine#48251) 2023-12-01 [email protected] [Impeller] Fix size of squares in DrawPoints(PointMode). (flutter/engine#48547) 2023-12-01 [email protected] Roll Skia from ecf10008c8bd to 5849e2b1aa8f (2 revisions) (flutter/engine#48569) 2023-12-01 [email protected] Roll Skia from 0ed7f26b3adb to ecf10008c8bd (1 revision) (flutter/engine#48568) 2023-12-01 [email protected] Roll Skia from e69fbf086bb6 to 0ed7f26b3adb (1 revision) (flutter/engine#48565) 2023-12-01 [email protected] Roll Skia from 57c6a5a97dc5 to e69fbf086bb6 (1 revision) (flutter/engine#48562) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Fixes: flutter/flutter#138877
The existing golden tests were already showing this bug, but we didn't see it. With this fix the size of the squares should be the same as the circle for the round caps in the DrawPoints playground goldens.
Test exemption request: This fix is covered by existing golden tests.