This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Support for decimal and signed numeric keyboard #4853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Assuming the Java and ObjC code is syntactically correct, LGTM. Can you think of a way we could test this? |
Member
|
LGTM |
cbracken
reviewed
Mar 23, 2018
| static const char _kTextAffinityUpstream[] = "TextAffinity.upstream"; | ||
|
|
||
| static UIKeyboardType ToUIKeyboardType(NSString* inputType) { | ||
| static UIKeyboardType ToUIKeyboardType(NSDictionary* type) { |
Member
There was a problem hiding this comment.
Optional - here and above: Maybe slightly cleaner to break out (NSString *inputType, BOOL signed)?
Contributor
Author
There was a problem hiding this comment.
Refactored a bit. But can't dereference bool earlier since it could be null here.
cbracken
approved these changes
Mar 23, 2018
Member
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#14916.
Requires flutter/flutter#15846.