Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@aam
Copy link
Member

@aam aam commented Mar 22, 2018

Roll dart to af14369.

Changes since last dart roll:

af1436931b [CFE] Fix for insertion of duplicate NSM forwarders
48644d5f6a [CFE] Fix crash when trying to add NSM forwarder for a field
898260a998 Split dependency on dart:html from dart:js
ef919c5eb3 fix commit queue: update nSM test expectation on ddc too.
d014fce4de Update dartkp NSM expectations.
6bd38cc912 Analysis Server API for 'Extract Widget' refactoring.
123e59c189 Improve for loop recovery
790b7b98fb [kernel] Update more NSM expectations.
696be0ae46 Initial support for extracting methods.
8d669c9d4e [kernel] Update NSM-forwarding test expectations.
edf039d510 [ VM / Dart 2 ] Made StackMapGC test strong-mode clean. Fixes part of 32190.
77239ee1db [fuchsia] Replace use of deprecated fdio_get_vmo with fdio_get_vmo_clone.

aam added 2 commits March 22, 2018 15:44
Changes since last dart roll:

```
af14369 (HEAD, origin/master, origin/HEAD) [CFE] Fix for insertion of duplicate NSM forwarders
48644d5 [CFE] Fix crash when trying to add NSM forwarder for a field
898260a Split dependency on dart:html from dart:js
ef919c5 fix commit queue: update nSM test expectation on ddc too.
d014fce Update dartkp NSM expectations.
6bd38cc Analysis Server API for 'Extract Widget' refactoring.
123e59c Improve for loop recovery
790b7b9 [kernel] Update more NSM expectations.
696be0a Initial support for extracting methods.
8d669c9 [kernel] Update NSM-forwarding test expectations.
edf039d [ VM / Dart 2 ] Made StackMapGC test strong-mode clean. Fixes part of 32190.
77239ee [fuchsia] Replace use of deprecated fdio_get_vmo with fdio_get_vmo_clone.
```
@aam aam requested a review from alexmarkov March 22, 2018 22:47
Copy link
Contributor

@alexmarkov alexmarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aam aam merged commit 7d9728d into flutter:master Mar 22, 2018
@aam aam deleted the roll-flutter-20180322a branch March 22, 2018 23:20
aam added a commit to aam/engine that referenced this pull request Mar 23, 2018
@aam aam mentioned this pull request Mar 23, 2018
aam added a commit that referenced this pull request Mar 23, 2018
* Revert "Roll back pub upgrade. (#4854)"

This reverts commit fc834f3.

* Revert "Roll flutter 20180322a (#4852)"

This reverts commit 7d9728d.

* Revert "Roll dart to 95e9e89 (#4850)"

This reverts commit 288fe3e.
cbracken added a commit to cbracken/flutter that referenced this pull request Mar 27, 2018
Includes:
* Remove declaration for undefined GPUSurfaceGL::SelectPixelConfig (flutter/engine#4857)
* Vulkan swap chain setup no longer uses GrPixelConfig and doesn't incl…
* Revert dart roll 20180322 (flutter/engine#4855)
* Roll back pub upgrade. (flutter/engine#4854)
* Roll flutter 20180322a (flutter/engine#4852)
* Document Window.defaultRouteName a little better. (flutter/engine#4851)
* Roll dart to 95e9e890a9 (flutter/engine#4850)
cbracken added a commit to flutter/flutter that referenced this pull request Mar 27, 2018
Includes:
* Remove declaration for undefined GPUSurfaceGL::SelectPixelConfig (flutter/engine#4857)
* Vulkan swap chain setup no longer uses GrPixelConfig and doesn't incl…
* Revert dart roll 20180322 (flutter/engine#4855)
* Roll back pub upgrade. (flutter/engine#4854)
* Roll flutter 20180322a (flutter/engine#4852)
* Document Window.defaultRouteName a little better. (flutter/engine#4851)
* Roll dart to 95e9e890a9 (flutter/engine#4850)
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
Includes:
* Remove declaration for undefined GPUSurfaceGL::SelectPixelConfig (flutter/engine#4857)
* Vulkan swap chain setup no longer uses GrPixelConfig and doesn't incl…
* Revert dart roll 20180322 (flutter/engine#4855)
* Roll back pub upgrade. (flutter/engine#4854)
* Roll flutter 20180322a (flutter/engine#4852)
* Document Window.defaultRouteName a little better. (flutter/engine#4851)
* Roll dart to 95e9e890a9 (flutter/engine#4850)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants