This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix GPUSurfaceGL includes on Linux #4849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
|
|
cbracken
reviewed
Mar 22, 2018
| return (x); \ | ||
| } | ||
| #if OS_MACOSX && !OS_IOS | ||
| #if (OS_MACOSX && !OS_IOS) || OS_LINUX |
Member
There was a problem hiding this comment.
I'm assuming OS_LINUX isn't true for OS_ANDROID?
context: paranoia based on OS_MACOSX && OS_IOS being true for iOS simulator builds. A little less paranoid for Android due to use of emulators there.
Member
Author
There was a problem hiding this comment.
yes - OS_LINUX is only set for host Linux
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Mar 27, 2018
Includes: * Fix GPUSurfaceGL includes on Linux (flutter/engine#4849) * Slightly improve the docs for the internal _futurize method (flutter/engine#4847) * Fix supported color type check on iOS simulators (flutter/engine#4846) * Fix GPUSurfaceGL includes on macOS (flutter/engine#4844) * Handle Apple-specific GLES headers (flutter/engine#4843) * [fuchsia] Fix up includes of Zircon headers (flutter/engine#4842) * VulkanSurface and GPUSurfaceGL no longer use GrPixelConfig (flutter/engine#4814)
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Mar 27, 2018
Includes: * Fix GPUSurfaceGL includes on Linux (flutter/engine#4849) * Slightly improve the docs for the internal _futurize method (flutter/engine#4847) * Fix supported color type check on iOS simulators (flutter/engine#4846) * Fix GPUSurfaceGL includes on macOS (flutter/engine#4844) * Handle Apple-specific GLES headers (flutter/engine#4843) * [fuchsia] Fix up includes of Zircon headers (flutter/engine#4842) * VulkanSurface and GPUSurfaceGL no longer use GrPixelConfig (flutter/engine#4814)
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
Mar 27, 2018
Includes: * Fix GPUSurfaceGL includes on Linux (flutter/engine#4849) * Slightly improve the docs for the internal _futurize method (flutter/engine#4847) * Fix supported color type check on iOS simulators (flutter/engine#4846) * Fix GPUSurfaceGL includes on macOS (flutter/engine#4844) * Handle Apple-specific GLES headers (flutter/engine#4843) * [fuchsia] Fix up includes of Zircon headers (flutter/engine#4842) * VulkanSurface and GPUSurfaceGL no longer use GrPixelConfig (flutter/engine#4814)
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Includes: * Fix GPUSurfaceGL includes on Linux (flutter/engine#4849) * Slightly improve the docs for the internal _futurize method (flutter/engine#4847) * Fix supported color type check on iOS simulators (flutter/engine#4846) * Fix GPUSurfaceGL includes on macOS (flutter/engine#4844) * Handle Apple-specific GLES headers (flutter/engine#4843) * [fuchsia] Fix up includes of Zircon headers (flutter/engine#4842) * VulkanSurface and GPUSurfaceGL no longer use GrPixelConfig (flutter/engine#4814)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.