This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll Skia version to abf7b763e2c1ba069942dedec914494817fd27a8 #4841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@brianosman |
Contributor
|
Do we need to LGTM these, or will the bot auto-merge on green? |
Contributor
|
We should give the bot the authority to autoland if the tree is green. |
cbracken
approved these changes
Mar 21, 2018
Member
|
lgtm |
Contributor
|
Yes, eventually the bot should autoland. Initially though it may require once a day manual approvals. |
Member
|
You can check the engine boxers are green in the build console. I believe there's a JSON API for this, so I assume we should be able to wire up a github presubmit hook like we have for the framework. Filed flutter/flutter#15807 |
Contributor
|
+1 to the presubmit hook request |
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Mar 27, 2018
Includes: * Roll Skia (flutter/engine#4841)
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Mar 27, 2018
Includes: * Roll Skia (flutter/engine#4841)
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
Mar 27, 2018
Includes: * Roll Skia (flutter/engine#4841)
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Includes: * Roll Skia (flutter/engine#4841)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.