This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[canvaskit] Fall back to drawImage for browsers that don't support createImageBitmap
#48336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would seriously consider dropping support for Safari 14 |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 28, 2023
…t support `createImageBitmap` (flutter/engine#48336)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 28, 2023
…139108) flutter/engine@5ffe1f4...96137d0 2023-11-28 [email protected] [canvaskit] Fall back to `drawImage` for browsers that don't support `createImageBitmap` (flutter/engine#48336) 2023-11-28 [email protected] Roll Fuchsia Linux SDK from qyRH6zYfUEjo9L1x2... to Vqcs_2rbtDfbmu3WX... (flutter/engine#48428) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from qyRH6zYfUEjo to Vqcs_2rbtDfb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers
pushed a commit
to caseycrogers/flutter
that referenced
this pull request
Dec 29, 2023
…lutter#139108) flutter/engine@5ffe1f4...96137d0 2023-11-28 [email protected] [canvaskit] Fall back to `drawImage` for browsers that don't support `createImageBitmap` (flutter/engine#48336) 2023-11-28 [email protected] Roll Fuchsia Linux SDK from qyRH6zYfUEjo9L1x2... to Vqcs_2rbtDfbmu3WX... (flutter/engine#48428) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from qyRH6zYfUEjo to Vqcs_2rbtDfb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari 14 doesn't have the
createImageBitmapAPI available. This change allows us to render intoRenderCanvaswithout usingcreateImageBitmapin that case.Fixes flutter/flutter#138910
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.