This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Delete unused/test only code from FML #48327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Nov 22, 2023
dnfield
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 23, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 23, 2023
…138954) flutter/engine@f331e0a...bec0dac 2023-11-23 [email protected] Fix not being able to hide iOS status bar via setEnabledSystemUIMode (flutter/engine#48271) 2023-11-22 [email protected] [web] Hook the new JS API to the FlutterViewManager (flutter/engine#48283) 2023-11-22 [email protected] Roll Skia from 3a79d7a618aa to 5606ef899116 (1 revision) (flutter/engine#48331) 2023-11-22 [email protected] Fix Share Screen Crash on iPad (flutter/engine#48220) 2023-11-22 [email protected] Delete unused/test only code from FML (flutter/engine#48327) 2023-11-22 [email protected] Roll Skia from 30ecaac60b47 to 3a79d7a618aa (1 revision) (flutter/engine#48328) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers
pushed a commit
to caseycrogers/flutter
that referenced
this pull request
Dec 29, 2023
…lutter#138954) flutter/engine@f331e0a...bec0dac 2023-11-23 [email protected] Fix not being able to hide iOS status bar via setEnabledSystemUIMode (flutter/engine#48271) 2023-11-22 [email protected] [web] Hook the new JS API to the FlutterViewManager (flutter/engine#48283) 2023-11-22 [email protected] Roll Skia from 3a79d7a618aa to 5606ef899116 (1 revision) (flutter/engine#48331) 2023-11-22 [email protected] Fix Share Screen Crash on iPad (flutter/engine#48220) 2023-11-22 [email protected] Delete unused/test only code from FML (flutter/engine#48327) 2023-11-22 [email protected] Roll Skia from 30ecaac60b47 to 3a79d7a618aa (1 revision) (flutter/engine#48328) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more-or-less a revert of #14011
This code never ended up being used outside of tests, and it's not how we handle asset loading at this point anyway.
I was hopeful we could kill off all runtime dependencies on Dart in
FMLwhen looking at this, but it looks like trace_event.h still wants to import dart_api_tools.h for some Dart enum types. This may or may not matter if we ever want to build FML for web/wasm. /cc @eyebrowsoffire. If we really need to do that, we can refactor the trace event stuff so that it has a web and Dart implementation that's selected at build time.