This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Load kernel files from the script URI in the isolate create callback #4828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
aam
reviewed
Mar 20, 2018
| // Entry script path (file:// is stripped). | ||
| entry_path = std::string(script_uri + strlen(kFileUriPrefix)); | ||
| if (!running_from_source) { | ||
| if (StringEndsWith(entry_path, ".dill")) { |
Member
There was a problem hiding this comment.
Can you clarify in comments how this works with kernel file named 'kernel_blob.bin' as defined by kKernelAssetKey here?
aam
approved these changes
Mar 20, 2018
Member
jason-simmons
force-pushed
the
bug_15731
branch
from
8524448 to
a708d6f
Compare
bsalomon
pushed a commit
to bsalomon/engine
that referenced
this pull request
Mar 21, 2018
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Mar 27, 2018
Includes: * Provide asset lookup key on ios (flutter/engine#4817) * Load kernel files from the script URI in the isolate create callback (flutter/engine#4828) * Remove some unneeded profiling flags (flutter/engine#4827) * Remove the canvas save/restore calls in Paragraph::Paint (flutter/engine#4822)
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
Mar 27, 2018
Includes: * Provide asset lookup key on ios (flutter/engine#4817) * Load kernel files from the script URI in the isolate create callback (flutter/engine#4828) * Remove some unneeded profiling flags (flutter/engine#4827) * Remove the canvas save/restore calls in Paragraph::Paint (flutter/engine#4822)
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Includes: * Provide asset lookup key on ios (flutter/engine#4817) * Load kernel files from the script URI in the isolate create callback (flutter/engine#4828) * Remove some unneeded profiling flags (flutter/engine#4827) * Remove the canvas save/restore calls in Paragraph::Paint (flutter/engine#4822)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#15731