This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] revert non-zero tessellation optimization. #48234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ping @dnfield |
Contributor
|
What PR does this (partially) revert? Can you link in the PR description? |
Contributor
Author
|
Done, sorry thought I linked that. |
matanlurey
approved these changes
Nov 27, 2023
Contributor
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
RSLGTM based on it being a revert. Thanks!
jonahwilliams
added
the
autosubmit
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this pull request
Nov 27, 2023
Forgot about the winding order. partially reverts flutter#46282 See flutter/flutter#138598 Reopens flutter/flutter#135458
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 27, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 27, 2023
…139095) flutter/engine@9fe1492...900ce09 2023-11-27 [email protected] Roll Skia from 743fc1cde518 to 4c964f8c4738 (2 revisions) (flutter/engine#48410) 2023-11-27 [email protected] [Impeller] revert non-zero tessellation optimization. (flutter/engine#48234) 2023-11-27 [email protected] Roll Skia from b0d81aba3f78 to 743fc1cde518 (3 revisions) (flutter/engine#48406) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jonahwilliams
pushed a commit
to jonahwilliams/engine
that referenced
this pull request
Nov 28, 2023
Forgot about the winding order. partially reverts flutter#46282 See flutter/flutter#138598 Reopens flutter/flutter#135458
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
…48459) Fixes flutter/flutter#138598 Cherry pick request: flutter/flutter#139146
caseycrogers
pushed a commit
to caseycrogers/flutter
that referenced
this pull request
Dec 29, 2023
…lutter#139095) flutter/engine@9fe1492...900ce09 2023-11-27 [email protected] Roll Skia from 743fc1cde518 to 4c964f8c4738 (2 revisions) (flutter/engine#48410) 2023-11-27 [email protected] [Impeller] revert non-zero tessellation optimization. (flutter/engine#48234) 2023-11-27 [email protected] Roll Skia from b0d81aba3f78 to 743fc1cde518 (3 revisions) (flutter/engine#48406) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot about the winding order. partially reverts #46282
See flutter/flutter#138598
Reopens flutter/flutter#135458