This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove the canvas save/restore calls in Paragraph::Paint #4822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for flutter/flutter#15702 Skia was not drawing the paragraph's text blobs in some cases when a save/restore sequence is done around the canvas->translate call. The problem does not occur if an offsetting call to translate is made instead of the save/restore. Will need to work with Skia to find the root cause.
Member
Author
gspencergoog
approved these changes
Mar 20, 2018
Contributor
|
|
cbracken
approved these changes
Mar 20, 2018
bsalomon
pushed a commit
to bsalomon/engine
that referenced
this pull request
Mar 21, 2018
This is a workaround for flutter/flutter#15702 Skia was not drawing the paragraph's text blobs in some cases when a save/restore sequence is done around the canvas->translate call. The problem does not occur if an offsetting call to translate is made instead of the save/restore. Will need to work with Skia to find the root cause.
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Mar 27, 2018
Includes: * Provide asset lookup key on ios (flutter/engine#4817) * Load kernel files from the script URI in the isolate create callback (flutter/engine#4828) * Remove some unneeded profiling flags (flutter/engine#4827) * Remove the canvas save/restore calls in Paragraph::Paint (flutter/engine#4822)
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
Mar 27, 2018
Includes: * Provide asset lookup key on ios (flutter/engine#4817) * Load kernel files from the script URI in the isolate create callback (flutter/engine#4828) * Remove some unneeded profiling flags (flutter/engine#4827) * Remove the canvas save/restore calls in Paragraph::Paint (flutter/engine#4822)
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Includes: * Provide asset lookup key on ios (flutter/engine#4817) * Load kernel files from the script URI in the isolate create callback (flutter/engine#4828) * Remove some unneeded profiling flags (flutter/engine#4827) * Remove the canvas save/restore calls in Paragraph::Paint (flutter/engine#4822)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for flutter/flutter#15702
Skia was not drawing the paragraph's text blobs in some cases when a
save/restore sequence is done around the canvas->translate call. The
problem does not occur if an offsetting call to translate is made instead
of the save/restore. Will need to work with Skia to find the root cause.