This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Only run systrace test on API 29+, avoid building scenario app for 28 #48163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Nov 17, 2023
dnfield
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 17, 2023
…138599) flutter/engine@5064aef...90c3ada 2023-11-17 [email protected] Roll Dart SDK from 12c5efc94edf to 46e8b18047eb (1 revision) (flutter/engine#48168) 2023-11-17 [email protected] Roll Skia from c7d2a4933dfa to c8ee25282849 (2 revisions) (flutter/engine#48164) 2023-11-17 [email protected] Only run systrace test on API 29+, avoid building scenario app for 28 (flutter/engine#48163) 2023-11-17 [email protected] Make `lib/ui/text/...` compatible with `.clang-tidy`. (flutter/engine#48156) 2023-11-17 [email protected] Make `flow/...` compatible with `.clang_tidy`. (flutter/engine#48148) 2023-11-17 [email protected] [Impeller] Add support for external GL textures to TiledTextureContents. (flutter/engine#47586) 2023-11-17 [email protected] Roll Dart SDK from 906f23c1cb20 to 12c5efc94edf (1 revision) (flutter/engine#48157) 2023-11-17 [email protected] Roll Skia from 762d95ed65e0 to c7d2a4933dfa (1 revision) (flutter/engine#48159) 2023-11-16 [email protected] [canvaskit] Size the PictureRecorder when calling Scene.toImage (flutter/engine#48142) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emulator tests I added yesterday are failing because the systrace python test script uses features introduced in API 29, which causes the
perfettoinvocation to fail.It's not essential that we run this test on lower API levels, so instead I'm making the script bail out in this case.
Other than that, the shard seems to be consistently passing, so I'm removing bringup.