Make shell/platform/{darwin|embedder}/... compatible with .clang-tidy.
#48160
Conversation
matanlurey
added
the
test: all
|
|
||
| #ifndef FLUTTER_ENGINE_NO_PROTOTYPES | ||
|
|
||
| // NOLINTBEGIN(google-objc-function-naming) |
There was a problem hiding this comment.
Is there a way for us to not apply google-objc-function-naming to non-Objective-C headers?
We should apply it to headers under //flutter/shell/platform/darwin, but most of the repo should be treated as C/C++.
There was a problem hiding this comment.
My guess is because this is imported by Obj-C code, it assumes it's Obj-C.
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
The changes under //flutter/shell/platform/darwin lgtm. I'd prefer we adjust the linting config for embedder.h so we're not running unwanted linters on it.
I unfortunately don't think there is a configuration option for what we want. I'm of the mind that the NOLINT markers are the lesser of evils here, though defer to you. |
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
lgtm; would be nice to find a way to tell the linter somehow that embedder.h is a C header.
matanlurey
added
the
autosubmit
…138658) flutter/engine@5f40c9f...384f750 2023-11-18 [email protected] Make `impeller/...` compatible with `.clang-tidy`. (flutter/engine#48155) 2023-11-18 [email protected] Make `shell/platform/{darwin|embedder}/...` compatible with `.clang-tidy`. (flutter/engine#48160) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
No description provided.