This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Make impeller/aiks/... compatible with .clang-tidy.
#48152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
added
the
test: all
gaaclarke
approved these changes
Nov 17, 2023
impeller/aiks/canvas_recorder.h
Outdated
| /// golden tests can be written at a higher level, migrate these to | ||
| /// flutter::DisplayListOpType. | ||
| enum CanvasRecorderOp : uint16_t { | ||
| // NOLINTBEGIN(readability-identifier-naming) |
Member
There was a problem hiding this comment.
You don't just want to rename them?
Contributor
Author
There was a problem hiding this comment.
I could. It caused problems with a macro used to map to something else, but maybe I was just tired at the time. I can give it a second shot.
Contributor
Author
There was a problem hiding this comment.
Ok I was just being lazy, this seems fine :)
matanlurey
force-pushed
the
engine-tidy-aiks
branch
from
bf85a58 to
258c076
Compare
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 18, 2023
…138650) flutter/engine@c38272b...1d2ee54 2023-11-17 [email protected] Make `impeller/aiks/...` compatible with `.clang-tidy`. (flutter/engine#48152) 2023-11-17 [email protected] Fix a few typos (flutter/engine#47960) 2023-11-17 [email protected] Roll Skia from 04b0ac194443 to 11b5847aea97 (3 revisions) (flutter/engine#48188) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.