This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Assign mojom kSwitch role to switches
#48146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaakovschectman
requested review from
cbracken,
gspencergoog,
huycozy and
loic-sharma
cbracken
approved these changes
Nov 17, 2023
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
Looks great! Thanks for fixing!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 17, 2023
…138637) flutter/engine@90c3ada...141a01c 2023-11-17 [email protected] Reland "[Impeller] Fail if software backend is chosen and Impeller is enabled on iOS." (flutter/engine#46275) 2023-11-17 [email protected] Make `impeller/geometry/...` compatible with `.clang-tidy`. (flutter/engine#48154) 2023-11-17 [email protected] Make `impeller/{archivist|compiler|core|entity}/...` compatible with â�¦ (flutter/engine#48153) 2023-11-17 [email protected] Assign mojom `kSwitch` role to switches (flutter/engine#48146) 2023-11-17 [email protected] [web] Move scene DOM management to DomManager (flutter/engine#47460) 2023-11-17 [email protected] [Impeller] Unify around "transform" (flutter/engine#48184) 2023-11-17 [email protected] Roll Dart SDK from a9c212f2f54b to 03cddb5d740d (1 revision) (flutter/engine#48182) 2023-11-17 [email protected] Actually make `status_or.h` compatible with `.clang-tidy`. (flutter/engine#48151) 2023-11-17 [email protected] [Impeller] Cleanups to geometry interfaces. (flutter/engine#48180) 2023-11-17 [email protected] [web] Move all DOM creation to DomManager (flutter/engine#48123) 2023-11-17 [email protected] Reenable UnobstructedPlatformViewTests testMultiplePlatformViewsWithOverlays (flutter/engine#48139) 2023-11-17 [email protected] Roll Dart SDK from 46e8b18047eb to a9c212f2f54b (1 revision) (flutter/engine#48176) 2023-11-17 [email protected] Roll Skia from bcd22e8f95bc to 8e9e168418a0 (1 revision) (flutter/engine#48173) 2023-11-17 [email protected] Roll Fuchsia Linux SDK from M0zM3CJLIrd5lb0u0... to Bcq9TZdt-vtTSL5YH... (flutter/engine#48172) 2023-11-17 [email protected] Roll Skia from c8ee25282849 to bcd22e8f95bc (1 revision) (flutter/engine#48170) 2023-11-17 [email protected] [Flutter GPU] Add Textures. (flutter/engine#48118) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from M0zM3CJLIrd5 to Bcq9TZdt-vtT If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have previously been using the
kToggleButtonrole for any widget that has a toggled state. Our AX library does not expect this role to be used for switches, and so would not assign the checked state to switches for MSAA. As far as I can tell, theSwitchis the only widget that uses thetoggledsemantic property (ToggleButtons, ironically, does not), so we ought to be able to swap in thekSwitchrole, for which the proper states are presented. This will allow screen readers to announce the state of a switch.flutter/flutter#138500
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.