Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@bsalomon
Copy link
Contributor

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@bsalomon
Copy link
Contributor Author

@jason-simmons, I think this is actually ready now. Would you mind landing it?

@jason-simmons jason-simmons merged commit 60befc2 into flutter:master Mar 21, 2018
@bsalomon bsalomon deleted the bert branch March 21, 2018 21:14
@bsalomon
Copy link
Contributor Author

Thanks!

@cbracken
Copy link
Member

This appears to have broken the Mac build: logs

@cbracken
Copy link
Member

Should have a patch momentarily

cbracken added a commit to cbracken/flutter that referenced this pull request Mar 27, 2018
Includes:
* Fix GPUSurfaceGL includes on Linux (flutter/engine#4849)
* Slightly improve the docs for the internal _futurize method (flutter/engine#4847)
* Fix supported color type check on iOS simulators (flutter/engine#4846)
* Fix GPUSurfaceGL includes on macOS (flutter/engine#4844)
* Handle Apple-specific GLES headers (flutter/engine#4843)
* [fuchsia] Fix up includes of Zircon headers (flutter/engine#4842)
* VulkanSurface and GPUSurfaceGL no longer use GrPixelConfig (flutter/engine#4814)
cbracken added a commit to cbracken/flutter that referenced this pull request Mar 27, 2018
Includes:
* Fix GPUSurfaceGL includes on Linux (flutter/engine#4849)
* Slightly improve the docs for the internal _futurize method (flutter/engine#4847)
* Fix supported color type check on iOS simulators (flutter/engine#4846)
* Fix GPUSurfaceGL includes on macOS (flutter/engine#4844)
* Handle Apple-specific GLES headers (flutter/engine#4843)
* [fuchsia] Fix up includes of Zircon headers (flutter/engine#4842)
* VulkanSurface and GPUSurfaceGL no longer use GrPixelConfig (flutter/engine#4814)
cbracken added a commit to flutter/flutter that referenced this pull request Mar 27, 2018
Includes:
* Fix GPUSurfaceGL includes on Linux (flutter/engine#4849)
* Slightly improve the docs for the internal _futurize method (flutter/engine#4847)
* Fix supported color type check on iOS simulators (flutter/engine#4846)
* Fix GPUSurfaceGL includes on macOS (flutter/engine#4844)
* Handle Apple-specific GLES headers (flutter/engine#4843)
* [fuchsia] Fix up includes of Zircon headers (flutter/engine#4842)
* VulkanSurface and GPUSurfaceGL no longer use GrPixelConfig (flutter/engine#4814)
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
Includes:
* Fix GPUSurfaceGL includes on Linux (flutter/engine#4849)
* Slightly improve the docs for the internal _futurize method (flutter/engine#4847)
* Fix supported color type check on iOS simulators (flutter/engine#4846)
* Fix GPUSurfaceGL includes on macOS (flutter/engine#4844)
* Handle Apple-specific GLES headers (flutter/engine#4843)
* [fuchsia] Fix up includes of Zircon headers (flutter/engine#4842)
* VulkanSurface and GPUSurfaceGL no longer use GrPixelConfig (flutter/engine#4814)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants