[Impeller] Clang tidy even more #48102
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
The presub failures look dubious. It looks like an API change on iOS. Perhaps the Xcode SDK was updated? I'll rebase and try again. But the error is likely unrelated to this PR. |
|
This PR needs to add an |
jonahwilliams
added
the
autosubmit
…138585) flutter/engine@aae07e9...5064aef 2023-11-16 [email protected] [Impeller] Clang tidy even more (flutter/engine#48102) 2023-11-16 [email protected] [Impeller] Implements gaussian blur that scales down before applying the blur (flutter/engine#47576) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
4 participants
Also removes alot of includes of fml macros, which I know is always safe to remove.