In the scenario game loop test, cancel the results writer task if the activity has been destroyed #48051
Conversation
… activity has been destroyed This test is run on Firebase Test Lab, and crashes have been reported on CI if this task executes when the activity is in a destroyed state. See flutter/flutter#138451
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
This approach sounds reasonable to me, though I don't have full context into the intention of the test.
|
Will this test fail when the code under test has a problem? I havent spent much time in this file but it seems that if the activity was launched then immediately killed this would cause a false positive. |
|
Currently the test will crash if Android closes the activity. The host environment can close any activity at any time, and the activity should be resilient to this. |
I think my point is that the test might be marked passing even if the code that the test is supposed to test is failing. That said I dont understand what is happening here and clearly you do so RSLGTM. |
reidbaker
added
the
autosubmit
|
Do you have a link I can use to monitor these tests so i can know when they should be marked as non flakey? |
|
These tests are run as part of the Watch the history of that builder at: |
…ask if the activity has been destroyed (flutter/engine#48051)
…138499) flutter/engine@f58dac6...7c2b8d5 2023-11-15 [email protected] In the scenario game loop test, cancel the results writer task if the activity has been destroyed (flutter/engine#48051) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
This test is run on Firebase Test Lab, and crashes have been reported on CI if this task executes when the activity is in a destroyed state.
See flutter/flutter#138451