This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Eliminate unused OCMock includes #48031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the broader quest to reduce our dependence on OCMock in macOS embedder tests, this removes #includes of OCMock into files where OCMock is not actually used.
matanlurey
approved these changes
Nov 14, 2023
yaakovschectman
approved these changes
Nov 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 14, 2023
…138441) flutter/engine@f15b259...c5a067b 2023-11-14 [email protected] Roll Skia from 650913eacd01 to 15a2577b12c1 (1 revision) (flutter/engine#48036) 2023-11-14 [email protected] Roll Skia from 6feae2c274ce to 650913eacd01 (1 revision) (flutter/engine#48034) 2023-11-14 [email protected] [macOS] Eliminate unused OCMock includes (flutter/engine#48031) 2023-11-14 [email protected] [ios17][text_input]fix ios 17.0 keyboard freeze when switching languages (without relying on text affinity) (flutter/engine#47566) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the broader quest to reduce our dependence on OCMock in macOS embedder tests, this removes #includes of OCMock into files where OCMock is not actually used.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.