This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Move EmbeddingStrategy and DimensionsProvider out of FlutterViewEmbedder
#48025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
(I think this PR Fixes, or is also part of: flutter/flutter#117098) |
ditman
approved these changes
Nov 14, 2023
Comment on lines
+61
to
+62
| ) : embeddingStrategy = EmbeddingStrategy.create(hostElement: hostElement), | ||
| _dimensionsProvider = DimensionsProvider.create(hostElement: hostElement); |
Member
There was a problem hiding this comment.
This is good for this review, but eventually the DimensionsProvider should be returned by the EmbeddingStrategy I think, they're slightly different "views" of the same hostElement.
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2023
… of `FlutterViewEmbedder` (flutter/engine#48025)
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 15, 2023
…138489) flutter/engine@ecaf944...d22d063 2023-11-15 [email protected] Reverts Dart to 3.3.0-135.0.dev (flutter/engine#48070) 2023-11-15 [email protected] [web] Move `EmbeddingStrategy` and `DimensionsProvider` out of `FlutterViewEmbedder` (flutter/engine#48025) 2023-11-15 [email protected] Roll Skia from d0e4a53f56f5 to 1abce6b0a763 (3 revisions) (flutter/engine#48067) 2023-11-15 [email protected] Roll Dart SDK from 849fd6ccc339 to 002e66832465 (1 revision) (flutter/engine#48065) 2023-11-15 [email protected] Roll Dart SDK from 65819963fb17 to 849fd6ccc339 (1 revision) (flutter/engine#48060) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#134443
Part of flutter/flutter#117098