Fix a few typos #47960
Fix a few typos #47960
Conversation
| result.setImportantForAccessibility(isImportant(semanticsNode)); | ||
| } | ||
|
|
||
| // Work around for https://github.com/flutter/flutter/issues/2101 |
There was a problem hiding this comment.
I believe this comment is still needed, but should be pushed down into the if/else block. Otherwise, LGTM! Thanks for helping improve the quality of our code comments.
There was a problem hiding this comment.
I didn't remove it, but changed the issue to the correct one. If you look at flutter/flutter#2101 you'll notice it has nothing to do with the comment, while flutter/flutter#22545 is the correct one.
mossmana
left a comment
mossmana
left a comment
There was a problem hiding this comment.
After some discussion with the original author, there was indeed a typo. The correct issue is actually flutter/flutter#21030. If you can make that update, this PR should be ready to merge.
|
Thanks for double-checking. I made the changes and squashed commits. |
bartekpacia
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/47960, due to - The status or check suite Linux Framework Smoke Tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
The changes to the comments should not have affected tests. So, you might need to try rebasing again. |
|
I'm going to use my commit-access priviliges for the first time and mark this with |
bartekpacia
added
the
autosubmit
|
wohoo |
…138650) flutter/engine@c38272b...1d2ee54 2023-11-17 [email protected] Make `impeller/aiks/...` compatible with `.clang-tidy`. (flutter/engine#48152) 2023-11-17 [email protected] Fix a few typos (flutter/engine#47960) 2023-11-17 [email protected] Roll Skia from 04b0ac194443 to 11b5847aea97 (3 revisions) (flutter/engine#48188) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
I found 3 small typos :)
Supersedes #47929
Pre-launch Checklist
///).