This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] JSConfig: Add multiViewEnabled value. #47939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
approved these changes
Nov 13, 2023
| /// Multi-view mode allows apps to: | ||
| /// | ||
| /// * Start without a `hostElement`. | ||
| /// * Add/remove views (`hostElements`) from JS while the application is running. |
Member
Author
|
Did I really break a pointer test with this? Odd. I'm going to rebase and see what CI thinks about my branch :/ |
ditman
commented
Nov 14, 2023
|
|
||
| external DomElement? get hostElement; | ||
|
|
||
| @JS('multiViewEnabled') |
Member
Author
There was a problem hiding this comment.
We can give any "external" (JS) name we want to this property, like "multiViewEnabledExperimental" or something scary like that. Do we need that, or do we just call it "multiViewEnabled"? @mdebbar?
Contributor
There was a problem hiding this comment.
I think it's fine to keep the name multiViewEnabled to avoid a little bit of churn down the line. Anyone who makes use of this flag ought to know that this is experimental and could break at any time.
Member
Author
There was a problem hiding this comment.
I think I agree with this!
Member
Author
|
I'll land this after @eyebrowsoffire "flutter.js in tests" PR lands, to not cause any conflicts on this end. |
ditman
force-pushed
the
add-multiview-toggle
branch
from
8395279 to
1a0aae0
Compare
Member
Author
|
Rebased and ready to land, applying |
ditman
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 15, 2023
…138457) flutter/engine@d7ca057...bc5bbd3 2023-11-15 [email protected] [web] JSConfig: Add multiViewEnabled value. (flutter/engine#47939) 2023-11-15 [email protected] [Impeller] Simplify convex tessellation (flutter/engine#47957) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change:
multiViewEnabled(defaults tofalse).canvasKitMaximumSurfacesvalue.Part of: flutter/flutter#137377
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.