Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@godofredoc
Copy link
Contributor

The fuchsia bucket does not have a delete ACL which is required to replace files that already exist. This change skips uploading the file if it already exists.

Bug: flutter/flutter#126461
Bug: flutter/flutter#135189

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

The fuchsia bucket does not have a delete ACL which is required to
replace files that already exist. This change skips uploading the file
if it already exists.

Bug: flutter/flutter#126461
Bug: flutter/flutter#135189
@godofredoc godofredoc requested a review from zanderso November 11, 2023 01:44
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2023
@auto-submit auto-submit bot merged commit 046ec85 into flutter:main Nov 13, 2023
@godofredoc godofredoc deleted the fix_fuchsia_script branch November 13, 2023 22:15
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 13, 2023
…138375)

flutter/engine@db6da00...046ec85

2023-11-13 [email protected] Fix fuchsia upload symbols. (flutter/engine#47938)
2023-11-13 [email protected] Roll Skia from 1a39bd56cda2 to 9ac5cad143ec (3 revisions) (flutter/engine#47984)
2023-11-13 [email protected] [web] - fix Safari textfield selection bug (flutter/engine#47917)
2023-11-13 [email protected] Roll Skia from 17b6555a1551 to 1a39bd56cda2 (2 revisions) (flutter/engine#47980)
2023-11-13 [email protected] Add a libcxxabi module that provides support for C++ thread-local storage (flutter/engine#47886)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants