This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Move Skia to //flutter/third_party/skia #47913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
force-pushed
the
move-skia
branch
2 times, most recently
from
9bb5950 to
71122fc
Compare
zanderso
force-pushed
the
move-skia
branch
7 times, most recently
from
1dc200f to
2138e67
Compare
Member
Author
|
https://skia-review.googlesource.com/c/skia-autoroll-internal-config/+/778396 to update the Skia autoroller config |
Member
Author
|
After approval, I'll stop the Skia autoroller, update the license goldens, land the changes, and then restart the autoroller. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 14, 2023
…138399) flutter/engine@d100e89...2c54b5f 2023-11-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 6219f11bf0fb to b3d3b381fd7b (1 revision)" (flutter/engine#48011) 2023-11-14 [email protected] Roll Skia from 9a45d3d77b31 to ab1b506c68a2 (1 revision) (flutter/engine#48007) 2023-11-14 [email protected] Move Skia to //flutter/third_party/skia (flutter/engine#47913) 2023-11-14 [email protected] Roll Dart SDK from 6219f11bf0fb to b3d3b381fd7b (1 revision) (flutter/engine#48006) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Member
|
zomg - nice work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of eliminating the Flutter buildroot (flutter/flutter#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party.
Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether.
To land this PR, we'll need to: