This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Temporarily disable test UnobstructedPlatformViewTests testMultiplePlatformViewsWithOverlays #47883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mViewsWithOverlays
cyanglaz
approved these changes
Nov 9, 2023
Contributor
cyanglaz
left a comment
cyanglaz
left a comment
There was a problem hiding this comment.
LGTM
FYI you can also skip xctest directly in code by adding a skipped_ before the test method.
vashworth
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2023
…MultiplePlatformViewsWithOverlays (flutter/engine#47883)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2023
…MultiplePlatformViewsWithOverlays (flutter/engine#47883)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2023
…MultiplePlatformViewsWithOverlays (flutter/engine#47883)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 10, 2023
…138231) flutter/engine@b020893...a5eab0d 2023-11-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 33307e78db2b to 5075ac874117 (3 revisions)" (flutter/engine#47909) 2023-11-10 [email protected] Temporarily disable test UnobstructedPlatformViewTests testMultiplePlatformViewsWithOverlays (flutter/engine#47883) 2023-11-10 [email protected] Roll Skia from 5075f1572bfe to e23e328584a1 (3 revisions) (flutter/engine#47900) 2023-11-10 [email protected] Roll Dart SDK from 33307e78db2b to 5075ac874117 (3 revisions) (flutter/engine#47899) 2023-11-10 [email protected] Roll Fuchsia Linux SDK from 0pD5ceqf-e9y9NTNn... to 8sk2n2-NXJ-ceyc7T... (flutter/engine#47898) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 0pD5ceqf-e9y to 8sk2n2-NXJ-c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
48 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnobstructedPlatformViewTests testMultiplePlatformViewsWithOverlaysseems to fail pretty flakily on macOS 13.6.1. Temporarily disabling until we can find a solution (flutter/flutter#138193).Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.