Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@auto-submit
Copy link
Contributor

@auto-submit auto-submit bot commented Nov 8, 2023

Reverts #47736
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Fixes flutter/flutter#133793

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Nov 8, 2023
@auto-submit auto-submit bot merged commit 21f055f into main Nov 8, 2023
@auto-submit auto-submit bot deleted the revert_2366ce60c19d81b7f288fe068dcddba3851dcc72 branch November 8, 2023 20:35
flar added a commit that referenced this pull request Nov 8, 2023
…Simple needed for DL dispatching" (#47821)"

This reverts commit 21f055f.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2023
auto-submit bot pushed a commit that referenced this pull request Nov 8, 2023
…eded for DL dispatching" (#47824)

Reverts #47821

The original PR was reverted because the Vulkan backends couldn't handle the extra tests, but they've since been patched to fix the problem.
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 8, 2023
…138111)

flutter/engine@5306213...21f055f

2023-11-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] add support for Skia concept of RRect::isSimple needed for DL dispatching" (flutter/engine#47821)
2023-11-08 [email protected] Roll Skia from fb69e696dc45 to e2b8ebe16203 (4 revisions) (flutter/engine#47815)
2023-11-08 [email protected] [Impeller] add support for Skia concept of RRect::isSimple needed for DL dispatching (flutter/engine#47736)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

e: impeller revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

[Impeller] Round rects with elliptical radii broken.

2 participants