This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Android] Bump robolectric version to support unit testing on Android 34 #47768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsim99
commented
Nov 9, 2023
|
|
||
| @Implements(FrameLayout.class) | ||
| public static class ShadowFrameLayout | ||
| extends io.flutter.plugin.platform.PlatformViewWrapperTest.ShadowViewGroup {} |
Contributor
Author
There was a problem hiding this comment.
Essentially, the issue here was that when you create a custom Robolectric shadow, it needs to imitate the object hierarchy of the object you are trying to shadow. Here (and in FlutterMutatorViewTest), we actually need to shadow FrameLayout, although it makes a call to its parent for the method whose behavior we want to mock (ViewGroup).
reidbaker
approved these changes
Nov 10, 2023
camsim99
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 10, 2023
…138237) flutter/engine@a5eab0d...77349dc 2023-11-10 [email protected] [Android] Bump robolectric version to support unit testing on Android 34 (flutter/engine#47768) 2023-11-10 [email protected] Roll Skia from ae6df7264c6e to 5df579e87784 (1 revision) (flutter/engine#47910) 2023-11-10 [email protected] [web] Move styling from FlutterViewEmbedder to StyleManager (flutter/engine#47489) 2023-11-10 [email protected] Roll Skia from e23e328584a1 to ae6df7264c6e (1 revision) (flutter/engine#47907) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps robolectric version from 4.10.3 --> 4.11 to support unit testing on Android 34!
Pre-launch Checklist
///).