This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] add support for Skia concept of RRect::isSimple needed for DL dispatching #47736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note that I didn't upgrade the RRect blurring fast path to deal with elliptical radii. If we had been receiving elliptical RRects before we might have been going through the fast path by mistake and now that I double check the parameters we might opt to do them the slow way. If this goes through, I'll file a bug to upgrade the RRect fast blur path to deal with elliptical radii. |
bdero
approved these changes
Nov 8, 2023
Member
bdero
left a comment
bdero
left a comment
There was a problem hiding this comment.
LGTM! I could have sworn we also had a user report this issue in the form of a mask blurred rrect with non-circular radii becoming circular.
zanderso
added
the
revert
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Nov 8, 2023
…eeded for DL dispatching" (#47821) Reverts #47736 Initiated by: zanderso This change reverts the following previous change: Original Description: Fixes flutter/flutter#133793
Member
|
The engine tree will hopefully recover now that #47781 has landed. This patch should be able to reland as-is. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 8, 2023
…needed for DL dispatching (flutter/engine#47736)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 8, 2023
…138111) flutter/engine@5306213...21f055f 2023-11-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] add support for Skia concept of RRect::isSimple needed for DL dispatching" (flutter/engine#47821) 2023-11-08 [email protected] Roll Skia from fb69e696dc45 to e2b8ebe16203 (4 revisions) (flutter/engine#47815) 2023-11-08 [email protected] [Impeller] add support for Skia concept of RRect::isSimple needed for DL dispatching (flutter/engine#47736) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#133793