[Impeller] Remove Rect field accesses from aiks subdirectory #47628
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bdero
left a comment
bdero
left a comment
There was a problem hiding this comment.
LGTM. I think this needs a no semantic change exemption?
|
I'd argue this does need a test, since the existing test suite doesn't seem to have one. E.g. Or in other words, lack of an existing test doesn't make a change test exempt. (Just a reminder, neither Brandon or I are authorized to declare this PR test exempt, so this is just our opinion and we wanted not to write tests, we'd have to ask one of the test-exemption owners) |
|
Just a note that the changes to ClipRRect which were ever so slightly more complicated than a simple "getter replacement" are already tested by the test suite here |
I had looked for |
|
test-exempt: code refactor with no semantic change |
…137871) flutter/engine@677040f...035740c 2023-11-03 [email protected] Roll Fuchsia Linux SDK from ho9FqsUD0hxh0b8to... to 8tJt8KJzTzbwwQlUE... (flutter/engine#47666) 2023-11-03 [email protected] Roll Fuchsia Mac SDK from y-hqwYkPPVT6RwmAS... to 5GLArzquQ4eL56vdy... (flutter/engine#47667) 2023-11-03 [email protected] Roll Skia from c0ca9f2fd828 to 77aeee3b81a5 (1 revision) (flutter/engine#47663) 2023-11-03 [email protected] [Impeller] Remove Rect field accesses from aiks subdirectory (flutter/engine#47628) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ho9FqsUD0hxh to 8tJt8KJzTzbw fuchsia/sdk/core/mac-amd64 from y-hqwYkPPVT6 to 5GLArzquQ4eL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
4 participants
These changes move any code in
impeller/aiksthat accessed the internal fields ofRectto using either the appropriate convenience methods for the operation or the getters for those properties.This is a simple code refactoring and should be covered by existing tests.