Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix race condition in Platform View Scenario tests #47575

Merged
auto-submit merged 1 commit into from
Nov 2, 2023
Merged

Fix race condition in Platform View Scenario tests #47575

auto-submit merged 1 commit into from
Nov 2, 2023

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Nov 1, 2023 •
edited
Loading

Fixes race condition in Platform View Scenario tests, see flutter/flutter#126627 for description of issue.

Fixes flutter/flutter#137547 and flutter/flutter#126627.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@vashworth vashworth marked this pull request as ready for review November 1, 2023 22:44
@vashworth vashworth requested a review from cyanglaz November 1, 2023 22:44
cyanglaz
cyanglaz approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for working on this!

@vashworth
Copy link
Contributor Author

vashworth commented Nov 2, 2023

I also validated it passed on macOS 13 https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac%20Engine%20Drone/11097/overview 🎉

@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 2, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2023
@auto-submit auto-submit bot merged commit 16d54bd into flutter:main Nov 2, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
16d54bda1 Fix race condition in Platform View Scenario tests (flutter…
a66e270 
…/engine#47575)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
Roll Flutter Engine from be49d6595ddd to 16d54bda1613 (1 revision) (#…
24adfe1 
…137774)

flutter/engine@be49d65...16d54bd

2023-11-02 [email protected] Fix race condition in Platform View Scenario tests (flutter/engine#47575)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@cyanglaz cyanglaz mentioned this pull request Nov 14, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Engine test PlatformViewMutationClipRectAfterMovedTests testPlatformView failing in CI on macOS 13

2 participants

@vashworth @cyanglaz