This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Wrap external texture tests in autorelease pool #47492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
requested review from
dkwingsmt,
goderbauer,
loic-sharma and
yaakovschectman
Wraps all FlutterExternalTexture tests in an autorelease pool to ensure
resources are cleaned up between tests.
Prior to this change, running these tests via:
../out/host_debug_unopt_arm64/flutter_desktop_darwin_unittests \
--gtest_filter='FlutterEmbedderExternalTextureUnittests.*'
Resuling in a segfault:
[ERROR:flutter/shell/platform/darwin/graphics/FlutterDarwinContextMetalSkia.mm(35)]
Could not create Metal command queue.
zsh: segmentation fault
../out/host_debug_unopt_arm64/flutter_desktop_darwin_unittests
Issue: flutter/flutter#104789
Issue: flutter/flutter#127441
Issue: flutter/flutter#124840
cbracken
changed the title
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 31, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 31, 2023
…137587) flutter/engine@44309c9...17eff7a 2023-10-31 [email protected] Roll Dart SDK from c8f75afabaf1 to 9cc76cb23b8c (1 revision) (flutter/engine#47498) 2023-10-30 [email protected] [macOS] Wrap external texture tests in autorelease pool (flutter/engine#47492) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Oct 31, 2023
…lutter#137587) flutter/engine@44309c9...17eff7a 2023-10-31 [email protected] Roll Dart SDK from c8f75afabaf1 to 9cc76cb23b8c (1 revision) (flutter/engine#47498) 2023-10-30 [email protected] [macOS] Wrap external texture tests in autorelease pool (flutter/engine#47492) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps all FlutterExternalTexture tests in an autorelease pool to ensure resources are cleaned up between tests.
Prior to this change, running these tests via:
Resuling in a segfault:
Issue: flutter/flutter#104789
Issue: flutter/flutter#127441
Issue: flutter/flutter#124840
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.