[web] Refactor a11y announcements out of FlutterViewEmbedder #47487
Conversation
|
The announcements host might be a full-blown global that all the views write to. I think one of the PRs that we got was to move the host "as lower down in the DOM as possible", so this might be something that we need to put near the end of the (I am not an expert, but TL;DR: this might not need a per-view implementation! |
|
I would prefer not to change the scope of this PR if possible. This PR is about moving the ownership of the a11y announcement element from Making a11y announcements global (i.e. in the That said, I'm working (in my head, nothing written yet) on a proposal to have a |
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
Ship it! I agree with having a <flutter-globals> area in the page, I don't see any way of escaping that.
…138174) flutter/engine@ca30d7d...0fae75f 2023-11-09 [email protected] [web] Refactor a11y announcements out of FlutterViewEmbedder (flutter/engine#47487) 2023-11-09 [email protected] Roll Skia from a58076ed871a to ff418c512205 (5 revisions) (flutter/engine#47871) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
FlutterViewEmbedder.FlutterViewEmbeddernorDomManager.Part of flutter/flutter#134443