Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Move scene DOM management to DomManager #47460

Merged
auto-submit merged 10 commits into from
Nov 17, 2023
Merged

[web] Move scene DOM management to DomManager #47460

auto-submit merged 10 commits into from
Nov 17, 2023

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Oct 30, 2023 •
edited
Loading

  • Move scene insertion logic to DomManager.
  • Add TODOs in Renderer subclasses (cc @harryterkelsen).

Part of flutter/flutter#134443

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Oct 30, 2023
ditman
ditman approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

(QQ: Is the idea that at some point the DomManager will create all the DOM that is needed for Flutter, rather than taking in the flutter view embedder, hence the DEPRECATED names?)

@mdebbar
Copy link
Contributor Author

mdebbar commented Oct 31, 2023

(QQ: Is the idea that at some point the DomManager will create all the DOM that is needed for Flutter, rather than taking in the flutter view embedder, hence the DEPRECATED names?)

Yes. That's what I'm working towards right now. I need many other changes though, before I can move DOM creation to DomManager.

ditman
ditman reviewed Nov 9, 2023
View reviewed changes
harryterkelsen
harryterkelsen approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 17, 2023
@auto-submit auto-submit bot merged commit 24efcdd into flutter:main Nov 17, 2023
@mdebbar mdebbar deleted the dom_scene_host branch November 17, 2023 19:27
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 17, 2023
@engine-flutter-autoroll
24efcddcd [web] Move scene DOM management to DomManager (flutter/engi…
6ffaf4f 
…ne#47460)
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Nov 17, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 90c3ada3682c to 141a01c5c70b (16 revisions) (#…
30b6586 
…138637)

flutter/engine@90c3ada...141a01c

2023-11-17 [email protected] Reland "[Impeller] Fail if software backend is chosen and Impeller is enabled on iOS." (flutter/engine#46275)
2023-11-17 [email protected] Make `impeller/geometry/...` compatible with `.clang-tidy`. (flutter/engine#48154)
2023-11-17 [email protected] Make `impeller/{archivist|compiler|core|entity}/...` compatible with â�¦ (flutter/engine#48153)
2023-11-17 [email protected] Assign mojom `kSwitch` role to switches (flutter/engine#48146)
2023-11-17 [email protected] [web] Move scene DOM management to DomManager (flutter/engine#47460)
2023-11-17 [email protected] [Impeller] Unify around "transform" (flutter/engine#48184)
2023-11-17 [email protected] Roll Dart SDK from a9c212f2f54b to 03cddb5d740d (1 revision) (flutter/engine#48182)
2023-11-17 [email protected] Actually make `status_or.h` compatible with `.clang-tidy`. (flutter/engine#48151)
2023-11-17 [email protected] [Impeller] Cleanups to geometry interfaces. (flutter/engine#48180)
2023-11-17 [email protected] [web] Move all DOM creation to DomManager (flutter/engine#48123)
2023-11-17 [email protected] Reenable UnobstructedPlatformViewTests testMultiplePlatformViewsWithOverlays (flutter/engine#48139)
2023-11-17 [email protected] Roll Dart SDK from 46e8b18047eb to a9c212f2f54b (1 revision) (flutter/engine#48176)
2023-11-17 [email protected] Roll Skia from bcd22e8f95bc to 8e9e168418a0 (1 revision) (flutter/engine#48173)
2023-11-17 [email protected] Roll Fuchsia Linux SDK from M0zM3CJLIrd5lb0u0... to Bcq9TZdt-vtTSL5YH... (flutter/engine#48172)
2023-11-17 [email protected] Roll Skia from c8ee25282849 to bcd22e8f95bc (1 revision) (flutter/engine#48170)
2023-11-17 [email protected] [Flutter GPU] Add Textures. (flutter/engine#48118)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from M0zM3CJLIrd5 to Bcq9TZdt-vtT

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ditman ditman ditman approved these changes

@harryterkelsen harryterkelsen harryterkelsen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdebbar @ditman @harryterkelsen