Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@khalid586
Copy link
Contributor

A typo has been fixed.

  • Issue fix: Fixes a typo.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@khalid586
Copy link
Contributor Author

@maintainer please review this PR.

@khalid586
Copy link
Contributor Author

@zanderso @dkwingsmt Can you please review my PR?

@zanderso zanderso merged commit f4f35e4 into flutter:main Oct 31, 2023
@khalid586
Copy link
Contributor Author

@zanderso thanks man!

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 31, 2023
…137635)

flutter/engine@4da3e5b...39be0fc

2023-10-31 [email protected] [Impeller] OpenGLES MSAA Render Buffers (i.e. for stencils) (flutter/engine#47495)
2023-10-31 [email protected] [Impeller] Migrate unit tests to named Rect factories (flutter/engine#47430)
2023-10-31 [email protected] [Typo fixed] in DEPS (flutter/engine#47440)
2023-10-31 [email protected] [Impeller] Restore GLES GPU query times. (flutter/engine#47511)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Oct 31, 2023
…lutter#137635)

flutter/engine@4da3e5b...39be0fc

2023-10-31 [email protected] [Impeller] OpenGLES MSAA Render Buffers (i.e. for stencils) (flutter/engine#47495)
2023-10-31 [email protected] [Impeller] Migrate unit tests to named Rect factories (flutter/engine#47430)
2023-10-31 [email protected] [Typo fixed] in DEPS (flutter/engine#47440)
2023-10-31 [email protected] [Impeller] Restore GLES GPU query times. (flutter/engine#47511)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants