This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Makes PlatformViewsController view to use tracked event's action & pointer count #47424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have confirmed that this fix resolves flutter/flutter#111268 on my device (HUAWEI MediaPad M5 SHT-W09) 👍 |
Contributor
|
Hey in our PR template there is a checklist of items that we expect to see. It looks like you have done most of them but I have added them back for you. I will add, Thank you for your contribution! I appreciate you taking the time to fix this issue it looks great. |
Contributor
Contributor
|
Please add a unit test that will act as a regression test. That is, a test that captures the slow scrolling behaviour that this PR is fixing. |
Member
|
@academy3746 Are you able to make progress on this? |
Contributor
|
Friendly ping @dnfield and @johnmccutchan , it looks like this has a test but I can't vouch for it. PTAL |
Contributor
|
@johnmccutchan can you take a look when you get a chance? |
johnmccutchan
approved these changes
Dec 19, 2023
johnmccutchan
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/47424, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 19, 2023
…ction & pointer count (flutter/engine#47424)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 19, 2023
…140367) flutter/engine@42af8f1...bde7c61 2023-12-19 [email protected] Makes PlatformViewsController view to use tracked event's action & pointer count (flutter/engine#47424) 2023-12-19 [email protected] Roll Skia from 37a60129e019 to 27ab8a8d2a0d (1 revision) (flutter/engine#49213) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
…lutter#140367) flutter/engine@42af8f1...bde7c61 2023-12-19 [email protected] Makes PlatformViewsController view to use tracked event's action & pointer count (flutter/engine#47424) 2023-12-19 [email protected] Roll Skia from 37a60129e019 to 27ab8a8d2a0d (1 revision) (flutter/engine#49213) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue flutter/flutter#111268, flutter/flutter#106190
Motivation:
Modification:
PlatformViewsControllerview to usetracked event's action & pointer countResult:
Now PlatformView scrolls not slowly
Close Android PlatformView scrolls slowly. flutter#111268, WebView very slow when scrolling flutter#106190
I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with
///).I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.