This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Adds firebase test lab tests. #47320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FTL tests were not migrated during the v2 migration. Bug: flutter/flutter#136767
gmackall
reviewed
Oct 26, 2023
Member
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
Is there a way to confirm the step is being run in pre-submit? I don't see it in the steps for the linux_android_aot_engine check on the pr (https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_android_aot_engine/20257/overview), but maybe I'm looking in the wrong place?
gmackall
approved these changes
Oct 26, 2023
Member
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
Ah I see I have to click through on the display builds|android_profile_arm64 step, then I can see it. LGTM!
godofredoc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 26, 2023
…137363) flutter/engine@9363fe6...7c5c8f5 2023-10-26 [email protected] [Impeller] remove giant closure in EntityPass. (flutter/engine#47343) 2023-10-26 [email protected] Adds firebase test lab tests. (flutter/engine#47320) 2023-10-26 [email protected] Roll Skia from e1cc41ff84ca to 19e9ccf5f820 (1 revision) (flutter/engine#47342) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FTL tests were not migrated during the v2 migration.
Bug: flutter/flutter#136767
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.